ISSUE-16 - Staged removal of cargo core: #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add krates_utils module to map between cargo PackageId and cargo_metadata PackageId * Add methods to cli module to create cargo metadata and krates struct * Remove usage of cargo PackageId/Package from find module Signed-off-by: joshmc <[email protected]>
|
Looks good to me. Doing this decoupling from cargo in multiple PRs seems like a good idea as well, keep 'em coming! Edit: Your unyielding focus on test coverage is great, I'm rediscovering a long lost appreciation for TDD 👍 Reviewing and merging code with new tests in combination with proper CI is really the way to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo_metadata PackageId
Signed-off-by: joshmc [email protected]